fix bugs and enhance unit test coverage for all functions in pkg/util/validator.go #4505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolibali
changed the title
|
@dolibali please fix the DCO issue |
dolibali
force-pushed
the
add-unit-tests
branch
from
47befc9
to
d53818e
Compare
zhangzujian
reviewed
Sep 11, 2024
zhangzujian
reviewed
Sep 11, 2024
zhangzujian
reviewed
Sep 11, 2024
zhangzujian
reviewed
Sep 11, 2024
bobz965
reviewed
Sep 11, 2024
bobz965
reviewed
Sep 12, 2024
zhangzujian
approved these changes
Sep 18, 2024
bobz965
approved these changes
Sep 18, 2024
added 3 commits
September 18, 2024 10:34
…ions Signed-off-by: dolibali <[email protected]>
Signed-off-by: dolibali <[email protected]>
Signed-off-by: dolibali <[email protected]>
bobz965
force-pushed
the
add-unit-tests
branch
from
b89e08f
to
404b9a7
Compare
zcq98
pushed a commit
to zcq98/kube-ovn
that referenced
this pull request
Sep 18, 2024
…/validator.go (kubeovn#4505) * Fix bugs in validator.go and enhance unit test coverage for all functions --------- Signed-off-by: dolibali <[email protected]> Co-authored-by: dolibali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4504